[5.1] Bring back support for Carbon instances to Before and After validators

[MacWorks]

Prior to Laravel 5.1.32, the Before and After validation rules accepted Carbon instances and correctly validated them. In 5.1.32 the validateBefore and validateAfter methods were changed to return false if the value passed was not a string and in subsequent point released if it was not a string or a number.

In 5.1.32 the following check was added to both validateBefore and validateAfter

    if (! is_string($value)) {
        return false;
    }

They evolved to the following in 5.1.35

    if (! is_string($value) && ! is_numeric($value)) {
        return false;
    }

This PR expands the check to see if the value is also not a Carbon instance. Carbon instances are compatible with strtotime() while DateTime instances are not.

strtotime(new DateTime());
> PHP warning:  strtotime() expects parameter 1 to be string, object given on line 1

strtotime(new Carbon());
> 1462824036

I have a fair amount of code in my 5.1 project that has relied on Before and After properly validating Carbon instances. My only alternatives would be to override Laravel's validator which adds technical debt or modify a bunch of code to convert Carbon dates before validation.

Given 5.1 is an LTS, I would hope that it would continue to support validation of Carbon instances as it has for most of it's lifetime.

[GrahamCampbell]

Sorry, we don't backport features.

[MacWorks]

My apologies it's my first ever pull request and was good practice anyway.

However, I'm not entirely sure what you mean by "backport features". The way I see it it's fixing a bug that was introduced in 5.1.32 because prior to that validateBefore and validateAfter worked with Carbon instances.

[MacWorks]

To put it another way, validateBefore and validateAfter were changed to insure that the value passed was something that could be consumed by strtotime() and that change incorrectly omitted Carbon instances, in my view.

[carc1n0gen]

This sounds more like a bug fix than a backport

[MacWorks]

Makes me think you read the title and didn't actually look at it, TBH

[GrahamCampbell]

Your PR is adding support for passing a carbon object, which is a new feature.

[GrahamCampbell]

The way I see it it's fixing a bug that was introduced in 5.1.32 because prior to that validateBefore and validateAfter worked with Carbon instances.

Ok then, leaving this for Taylor to review.

[taylorotwell]

Thanks