Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Added support for different log levels. #13513

Merged
merged 1 commit into from
May 18, 2016
Merged

[5.2] Added support for different log levels. #13513

merged 1 commit into from
May 18, 2016

Conversation

melanholly
Copy link

This adds support for different logging levels that seems to be implemented but it was missing from this file. Now we can use different logging levels. If we switch from development to production we have different amount of logging information.

This is feature of Monolog and it was added in src/Illuminate/Log/Writer.php but not in src/Illuminate/Foundation/Bootstrap/ConfigureLogging.php

This functionality is not tested since it is part of Monolog.

@melanholly melanholly changed the title Added support for different log levels. [5.2] Added support for different log levels. May 11, 2016
@GrahamCampbell
Copy link
Member

I don't think this needs to go in the core. 👎 from me. I also would suggest a better way of doing it: https://github.com/AltThree/Logger.

@melanholly
Copy link
Author

OK so you suggest that I use different logging package if I have to use different log levels beside debug?
Well I just wanted to extend the support for Monolog so we can have different log levels for different environments.
Please close the issue if you think it shouldn't be in the core.

@taylorotwell taylorotwell merged commit fbd6e77 into laravel:5.2 May 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants