[5.2] Fix FileStore expiration #13708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
File cache only expects full minutes (probably seconds would has been a better choice, but that's another story). Your PR just rounds down the number of minutes: it doesn't add granularity, so it doesn't really improve the situation. This might also bring bugs elsewhere. |
|
Perhaps better to throw an exception if we overflowed. |
|
I'm not sure such an argument check is worth it. A number of minutes is expected, this is discussable, but for now deal with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying a float cache expiration breaks the FileStore cache, as the unserialize call in the getPayload method fails if the timestamp is greater than 10 characters. This PR prevents this by casting the expiration to int to ensure a 10 character timestamp