[5.1] Use write database connection when validating uniqueness #13718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be possible that when an application have a huge latency between master and slave that a novice user would reattempt to recreate an entry which is now only available on the master connection. When he/she create the record again which require unique value such as email it currently would only fetch from the slave database connection and would return pass, however when the application try to save the actual entry to the database it would fail due to unique (if we set it on the database). This solve the issue by always checking against master (write) connection. Signed-off-by: crynobone <crynobone@gmail.com>
|
This is almost similar with #12794 bugfix. |
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be possible that when an application have a huge latency
between master and slave that a novice user would reattempt to recreate
an entry which is now only available on the master connection.
When he/she create the record again which require unique value such as email
it currently would only fetch from the slave database connection and
would return pass, however when the application try to save the actual
entry to the database it would fail due to unique (if we set it on the
database).
This solve the issue by always checking against master (write)
connection.
Signed-off-by: crynobone crynobone@gmail.com