Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Invoke sendLogoutResponse method when logout #13816

Closed
wants to merge 1 commit into from
Closed

[5.2] Invoke sendLogoutResponse method when logout #13816

wants to merge 1 commit into from

Conversation

ElfSundae
Copy link
Contributor

Give app a chance to return custom response.

@ElfSundae ElfSundae changed the title Invoke sendLogoutResponse method when logout [5.2] Invoke sendLogoutResponse method when logout Jun 1, 2016
@GrahamCampbell
Copy link
Member

Surely you should just override the logout() method?

@ElfSundae
Copy link
Contributor Author

Just like AuthenticatesUsers::handleUserWasAuthenticated, maybe the controller wants to return a JSON response in this sendLogoutResponse method, or flash data.
Of cause we can overwrite or override the logout() method, but when the Laravel framework updates, we may should modify the overwritten method again if there are new features in the logout() method.

@ElfSundae
Copy link
Contributor Author

Ref. #13818

@taylorotwell
Copy link
Member

Just override the logout method. That is the intention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants