[5.2] Validation of dates - Dealing with DateTime instances #13844

KennedyTedesco · 2016-06-03T03:10:25Z

This PR allows to pass DateTime instances when validating using After and Before.

Ex:

validator(
   ['start' => new DateTime('2012-01-01'), 'ends' => new DateTime('2013-01-01')], 
   ['start' => 'date|Before:ends', 'ends' => 'date|After:start']
);

Or:

validator(
   ['start' => new Carbon('2012-01-01'), 'ends' => new Carbon('2013-01-01')], 
   ['start' => 'date|Before:ends', 'ends' => 'date|After:start']
);

GrahamCampbell · 2016-06-03T12:55:31Z

src/Illuminate/Validation/Validator.php

@@ -1758,19 +1757,19 @@ protected function validateBefore($attribute, $value, $parameters)
    {
        $this->requireParameterCount(1, $parameters, 'before');

-        if (! is_string($value) && ! is_numeric($value) && ! $value instanceof Carbon) {
+        if (! is_string($value) && ! is_numeric($value) && ! $value instanceof DateTime) {


Better to check for DateTimeInterface perhaps?

Good! Taylor already did, btw.

KennedyTedesco added 2 commits June 2, 2016 23:44

[5.2] Validation of dates - Dealing with DateTime instances

7bf4336

CS Fixes

247b414

GrahamCampbell reviewed Jun 3, 2016
View reviewed changes

taylorotwell merged commit 247b414 into laravel:5.2 Jun 3, 2016

KennedyTedesco deleted the validation-5.2 branch June 3, 2016 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.2] Validation of dates - Dealing with DateTime instances #13844

[5.2] Validation of dates - Dealing with DateTime instances #13844

KennedyTedesco commented Jun 3, 2016

GrahamCampbell Jun 3, 2016

KennedyTedesco Jun 3, 2016

[5.2] Validation of dates - Dealing with DateTime instances #13844

[5.2] Validation of dates - Dealing with DateTime instances #13844

Conversation

KennedyTedesco commented Jun 3, 2016

GrahamCampbell Jun 3, 2016

Choose a reason for hiding this comment

KennedyTedesco Jun 3, 2016

Choose a reason for hiding this comment