Update str_plural() to add intval($count)

[SaeedPrez]

A lot of the time when you use str_plural() you get the $count value from a form request which returns the number as a string and therefore this helper won't work as expected. This small change should make sure the $count is in integer format.

[barryvdh]

Shouldn't that happen in the Pluralizer class?

framework/src/Illuminate/Support/Pluralizer.php

Lines 51 to 60 in 802f42f

	public static function plural($value, $count = 2)
	{
	if ($count === 1 || static::uncountable($value)) {
	return $value;
	}
	$plural = Inflector::pluralize($value);
	return static::matchCase($plural, $value);
	}

[SaeedPrez]

Hi Barry,

It doesn't return in singular when I try str_plural('car', $request->input('quantity')); where quantity is a HTML number field. However it does work as expected when I use it with intvar().

Also when I try var_dump($request->input('quantity)) it gives me string "1".

Another option would be to change $count === 1 to $count == 1 in Pluralizer.php

[barryvdh]

I meant that you can do the intval() casting further down the code. Now your just fixing the helper, not the Str::plural() method or the Pluralizer class itself.

[SaeedPrez]

Ah, sorry.. I thought you meant it should already happen there.

This is my first pull request ever ☺ Should I close this and make a new pull request for the Pluralizer.php?

[SaeedPrez]

Closing this one as I've created a new pull request as suggested..

#14502