[5.2] Allow collections to be created from objects that implement Traversable #14628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
|
This is a breaking change is it not? |
|
Well it’ll break for anyone who’s passing in an I think this is more fixing than breaking as this changes the behaviour to match |
tillkruss
pushed a commit
to tillkruss/framework
that referenced
this pull request
Aug 30, 2016
…versable (laravel#14628) * Allow collections to be created from objects that implement Traversable * Style fix; remove exta space character
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title suggests. I'm making use of the Collection code via tightenco/collect, and I had a use case where my data was contained within an object that implements Iterator.