-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Fixed the aggregate method #14781
Conversation
May be you should use “===” replace "!==" |
This should be reverted. Some aggregate functions can deal with strings and any existing application using this functionality is now broken. Furthermore, as @ganxiangdong mentioned this PR is bugged. @GrahamCampbell you are always very strict about adding tests and preventing behaviour changes in patch releases—which is good, don't get me wrong—yet completely fail to go by your own rules here. I don't understand. |
Why is the return annotation saying you cannot return anything but an int or a float then? |
This was an intentional behaviour change to correct it to match the documented return type. |
@GrahamCampbell I don't know why the annotation is like that, but why change the implementation in favour of changing the annotated return value? |
Ok, i'll fix this. |
Please see #14793. |
Basically reverted this. |
It is marked as only returning integers and floats, but it also can return
null
andstring
. That's not the correct behaviour.