[5.3] Fix line breaks in plain text email #15115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
changed the title
|
Why do we have to manually echo "\n"... why not just put actual line breaks in the file like you would a Blade template? |
|
@taylorotwell Because of the conditionals. We'd end up with weird blank lines in between sections. |
|
HTML collapses vertical line breaks and even horizontal spaces. Plain text emails are more like Markdown. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15108 broke the new-lines in the plain text email for notifications.
This PR fixes those line breaks.
For future PRs the importance of new-lines in plain text emails has been highlighted by only using echo statements in
email-plain.blade.php.CRLFs have been replaced by LFs, because SwiftMailer canonicalizes them anyhow.