Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Hide pagination if it does not have multiple pages #15246

Merged
merged 1 commit into from
Sep 5, 2016

Conversation

garygreen
Copy link
Contributor

Fixes #15125

@GrahamCampbell GrahamCampbell changed the title Hide pagination if it does not have multiple pages [5.3] Hide pagination if it does not have multiple pages Sep 3, 2016
@JosephSilber
Copy link
Member

I'm not sure hiding the paginator is good UX. People will be looking for the pagination links.

@garygreen
Copy link
Contributor Author

@JosephSilber it's how 5.2 behaved and all previous Laravel versions, never had a problem. Have you taken a look at the screenshots in #15124 ? It looks pretty silly to render those by default.

An alternative option could be to add a class to the paginator for paginator-empty when it detects there are not more than 1 page, that way the paginator can be easily hidden by css or styled differently if people wish.

@taylorotwell taylorotwell merged commit d45af77 into laravel:5.3 Sep 5, 2016
@taylorotwell
Copy link
Member

Did we actually test this one to see if it works :/

@garygreen
Copy link
Contributor Author

@garygreen garygreen deleted the fix-hide-empty-paginator branch September 7, 2016 10:04
tillkruss pushed a commit to tillkruss/framework that referenced this pull request Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants