[5.3] Fix fatal error on file uploads

[nhowell]

This PR fixes the code from #15250 which broke file uploads in Laravel 5.3.7.

Catchable fatal error: Object of class Symfony\Component\HttpFoundation\File\UploadedFile could not be converted to boolean in vendor\laravel\framework\src\Illuminate\Http\Request.php on line 883

You can't convert SplFileInfo, and therefore Symfony's UploadedFile, to a boolean. See: http://stackoverflow.com/questions/17488674/why-cant-splfileinfo-be-converted-to-boolean

Edit: I should add that it looks like this has been fixed at some point after PHP 5.6.4, but as 5.6.4 is the minimum version required for Laravel 5.3 I think this PR is still needed.

[themsaid]

@nhowell What version of PHP are you using? The issue you refer to is fixed since PHP 5.5.21 and laravel 5.3 requires PHP >=5.6.4.

[nhowell]

I'm using PHP 5.6.4 (for development purposes).

[themsaid]

Strange, can you please add a test to make sure it won't break in the future?

[nhowell]

The issue you refer to is fixed since PHP 5.5.21 and laravel 5.3 requires PHP >=5.6.4.

PHP 5.5.21 and PHP 5.6.5 were both released the same day, so it appears to me that PHP 5.6.4 did not contain the fix. It isn't clear to me from the PHP changelog when the fix landed in PHP 5.6, though.

[themsaid]

This test would do, please add it in tests/Http/HttpRequestTest.php to make sure things would work in the future.

public function testInputWithValidFile()
    {
        $files = [
            'file' => new Symfony\Component\HttpFoundation\File\UploadedFile(__FILE__, 'foo.php'),
        ];

        $baseRequest = SymfonyRequest::create('/?boom=breeze', 'GET', ['foo' => ['bar' => 'baz']], [], $files);

        $request = Request::createFromBase($baseRequest);

        $this->assertInstanceOf(\Symfony\Component\HttpFoundation\File\UploadedFile::class, $request->files->get('file'));
    }

[nhowell]

can you please add a test to make sure it won't break in the future?

How would one do that? The existing tests should cover it, right? But Travis CI is running the tests with PHP 5.6.5, and those tests pass, so the bug must've been fixed with PHP 5.6.5.