Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] change to loosey comparison to allow queue to run without --tries #15390

Merged
merged 1 commit into from
Sep 11, 2016
Merged

Conversation

bronxct1
Copy link

@bronxct1 bronxct1 commented Sep 11, 2016

Fixes the issue where running php artisan queue:listen marks jobs failed unless --tries=1

The issue is referenced in #15319

@GrahamCampbell GrahamCampbell changed the title change to loosey comparison to allow queue to run without --tries [5.3] change to loosey comparison to allow queue to run without --tries Sep 11, 2016
@GrahamCampbell
Copy link
Member

Surely we just need to set a correct default in the command. This fix doesn;t look correct?

@taylorotwell
Copy link
Member

Let's just revert the broken commit.

@taylorotwell taylorotwell reopened this Sep 11, 2016
@taylorotwell taylorotwell merged commit 43ebd2c into laravel:5.3 Sep 11, 2016
@GrahamCampbell
Copy link
Member

NB, this PR has just been reverted.

@larsbo
Copy link

larsbo commented Sep 12, 2016

Instead of switching back to loose comparing the parameters should be casted to int at the correct position. E.g. Instead doing it here: https://github.com/laravel/framework/blob/5.3/src/Illuminate/Queue/Worker.php#L242
casting may take place here: https://github.com/laravel/framework/blob/5.3/src/Illuminate/Queue/Console/ListenCommand.php#L98
See issue #15370 for more details.

@GrahamCampbell
Copy link
Member

@larsbo yeh, we already did this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants