[5.3] Added Container::getFactory() method
#15414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guiwoda
force-pushed
the
container-get-factory
branch
from
bea3565 to
d819bb5
Compare
GrahamCampbell
changed the title
Container::getFactory() methodContainer::getFactory() method
|
Adding a method to an interface is a major breaking change. Please send to 5.4. |
|
@GrahamCampbell I can drop the interface change here and add the BC in 5.4. |
|
@GrahamCampbell dude, can't you wait 2 minutes before closing, so I can respond? |
|
This doesn't avoid the fact that this interface would really need to be added to the contract. It's a bit naught to add something and not add it to the interface. There's also an issue with the phpdoc which I didn't mention originally because it would have been even more inflammatory. |
|
|
||
| /** | ||
| * Get a closure to resolve the given type from the container. | ||
| * The given closure will have an optional [array $parameters] parameter |
There was a problem hiding this comment.
Please add the missing newline here.
|
I seem unable to re-open this PR. |
|
It's a duplicate of #15415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow
Closurefactories to be easily made at entry point level, without having to injectContainerwhere only a single factory method is required.