Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Return a Database Collection from HasOneOrMany::createMany #15944

Merged
merged 4 commits into from
Oct 17, 2016
Merged

[5.4] Return a Database Collection from HasOneOrMany::createMany #15944

merged 4 commits into from
Oct 17, 2016

Conversation

colindecarlo
Copy link
Contributor

While there is enough information available to return something more useful, Illuminate\Database\Eloquent\Relation\HasOneOrMany::createMany returns an array. It should return an instance of Illuminate\Database\Eloquent\Collection based on the $related model.

Fixes #15943

@GrahamCampbell GrahamCampbell changed the title Return a Database Collection from HasOneOrMany::createMany [5.4] Return a Database Collection from HasOneOrMany::createMany Oct 17, 2016
@taylorotwell taylorotwell merged commit 48820f4 into laravel:master Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colindecarlo @taylorotwell