[5.3] Update Connection.php #16422
Merged
[5.3] Update Connection.php #16422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reconnectIfMissingConnection() calls getPdo(). This executes the callback which is not desired for read/write connections where the read is being used. Checking is_null($this->pdo) instead allows for the callback to not be called until it is needed.
|
This issue needs more explanation. I don't think your change looks correct. $this->pdo could be a Closure. |
|
That's exactly the point. When $this->getPdo() is called, the closure is called. However, for connections with separate read/write servers that closure shouldn't be called unless a write connection is needed. If $this->getPdo() is called, then the closure is called. So reconnectIfMissingConnection() needs to avoid calling $this->getPdo(). By looking at $this->pdo instead of $this->getPdo() the same result is obtained (see the code for getPdo()) without actually calling the closure. Without this patch, the write connection is connected to every time even when a query that should hit the read connection is being run. |
|
Issue: #15359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reconnectIfMissingConnection() calls getPdo(). This executes the callback which is not desired for read/write connections where the read is being used. Checking is_null($this->pdo) instead allows for the callback to not be called until it is needed.