[5.4] SqlServer join on delete #16618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixed a bug where using the join and calling the delete method passing an ID would throw an ambiguous error, ppl shouldn't do that but it's fixed just in case... |
taylorotwell
reviewed
Dec 1, 2016
| @@ -2247,7 +2247,7 @@ public function delete($id = null) | |||
| // the ID to allow developers to simply and quickly remove a single row | |||
| // from their database without manually specifying the where clauses. | |||
| if (! is_null($id)) { | |||
| $this->where('id', '=', $id); | |||
| $this->where($this->from.'.id', '=', $id); | |||
There was a problem hiding this comment.
Does this syntax cause any problems when you do a delete without a join? Does it care that you specify the table name in that case? We would need to verify that across all drivers.
There was a problem hiding this comment.
Yep, we need to verify that to be sure, it shouldn't cause any problems, but we should verify it just in case. I'll gather some feedback...
There was a problem hiding this comment.
I've tested online on http://sqlfiddle.com/ and it works for all drivers it doesn't care for the table name at all...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for join when deleting records using SqlServer, following the logic used on the MySQL grammar.
Example of the result:
Refs #16573