[5.4] Execute queries with lock only in write database #17386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianBerc
changed the title
|
I have no idea why StyleCI can't analysis this PR :/ |
GrahamCampbell
requested changes
Jan 18, 2017
| @@ -49,7 +49,7 @@ public function messages() | |||
| /** | |||
| * Clear all of the messages from the local collection. | |||
| * | |||
| * @return void | |||
| * @return Collection | |||
There was a problem hiding this comment.
Please don't make unrelated changes in the PR. This change also doesn't match our code standards anyway.
There was a problem hiding this comment.
I removed commit with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in PR #17317 but with the better solution and I added the test as a bug proof.
/cc @JoostK, @GrahamCampbell