Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.4] Fix persisting user and request info to session table #17584

Merged
merged 1 commit into from
Jan 26, 2017
Merged

[5.4] Fix persisting user and request info to session table #17584

merged 1 commit into from
Jan 26, 2017

Conversation

devcircus
Copy link
Contributor

Fixes #17581

Problem

The payload is correctly passed by reference in the addUserInformation and addRequestInformation methods, however, for the results of these two methods to be correctly merged with the payload, the payload must be passed by reference in the tap function of the getDefaultPayload method.

Before

Starting with a fresh laravel app, run php artisan session:table then php artisan make:auth.
Run php artisan migrate
Then log in and check your sessions table in the database.
The user id, ip address and user agent would be null.

After

Repeat the above steps and all columns will be populated correctly in db.

@devcircus devcircus changed the title fix persisting user and request info to session db [5.4] fix persisting user and request info to session table Jan 26, 2017
@devcircus devcircus changed the title [5.4] fix persisting user and request info to session table [5.4] Fix persisting user and request info to session table Jan 26, 2017
@taylorotwell taylorotwell merged commit 8aacf5c into laravel:5.4 Jan 26, 2017
@taylorotwell
Copy link
Member

Thanks

@devcircus devcircus deleted the fix-db-session branch January 26, 2017 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants