[5.4] Fix persisting user and request info to session table #17584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17581
Problem
The payload is correctly passed by reference in the addUserInformation and addRequestInformation methods, however, for the results of these two methods to be correctly merged with the payload, the payload must be passed by reference in the tap function of the getDefaultPayload method.
Before
Starting with a fresh laravel app, run
php artisan session:table
thenphp artisan make:auth
.Run
php artisan migrate
Then log in and check your sessions table in the database.
The user id, ip address and user agent would be null.
After
Repeat the above steps and all columns will be populated correctly in db.