[5.4] add default param to collection's when() method #17941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntzm
reviewed
Feb 15, 2017
| { | ||
| if ($value) { | ||
| return $callback($this); | ||
| } elseif ($default) { | ||
| return $default($this); |
There was a problem hiding this comment.
this elseif can just be an if
There was a problem hiding this comment.
Gonna leave that as is. Thats what we currently use for the eloquent QB and it works just fine for now
| @@ -315,10 +315,12 @@ public function filter(callable $callback = null) | |||
| * @param callable $callback | |||
There was a problem hiding this comment.
docblock needs updating as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the changes made in #17917 up to date with my original changes to the eloquent query builder made in #15428