[5.4] Suppress getimagesize() warnings #17944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getimagesize` will fail with a notice on files smaller than 12 bytes. This ends up becoming an ErrorException which is pretty annoying. Suppressing the warning is enough to still end up with a `false` result which will fail the validation gracefully instead of grueing up your stew.
GrahamCampbell
changed the title
taylorotwell
pushed a commit
that referenced
this pull request
Feb 18, 2017
* Suppress getimagesize() warnings Backport of #17944. `getimagesize` will fail with a notice on files smaller than 12 bytes. This ends up becoming an ErrorException which is pretty annoying. Suppressing the warning is enough to still end up with a `false` result which will fail the validation gracefully instead of grueing up your stew. * Proper float comparison in ratio validation * Convert fixtures to PNG format * Add test for validation of ratio with no fractional part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getimagesizewill fail with a notice on files smaller than 12 bytes.This ends up becoming an ErrorException which is pretty annoying.
Suppressing the warning is enough to still end up with a
falseresultwhich will fail the validation gracefully instead of grueing up your
stew.