[5.4] Fix route bindings #17973
Merged
[5.4] Fix route bindings #17973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems a lot more elegant than my solution in #16926, can't see any issues address in mine that haven't been addressed in this one (though haven't thought through too much the $values[$key - $instancesCount] maintaining the order of non object dependencies.) |
cgoosey1
reviewed
Feb 19, 2017
| * @return mixed | ||
| */ | ||
| protected function transformDependency(ReflectionParameter $parameter, $parameters, $originalParameters) | ||
| protected function transformDependency(ReflectionParameter $parameter, $parameters) |
There was a problem hiding this comment.
same feedback as appeared in mine, this can be type hinted :P
There was a problem hiding this comment.
protected function transformDependency(ReflectionParameter $parameter, array $parameters)
|
How about applying this bug fix to the previous, supposedly still supported versions? |
|
It's probably too controversial for earlier versions IMO. |
This was referenced Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another approach to fix #16926