[5.4] Allow Slack Notifications to use image urls #18011
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Laravel Notification channel for Slack seems to only support the 'icon_emoji'.
However Slack webhooks also allow you to provide an image URL - allowing you to use your own custom logo when sending a Slack notification - which is probably better for most Laravel Apps so they can include their logo?
This PR is fully BC. You can set a logo URL instead of an emoji:
p.s. I've tested this against the Slack API. If someone sets both an icon emoji and an icon image - Slack just uses the emoji with no complaints.