[5.4] add ability to pretty print response #18377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is very difficult to view the failure response, since everything is printed inline. this allows the options to ‘pretty print’ the JSON output, just like is done in the ‘additional info’.
browner12
changed the title
|
i'm having trouble fixing the test on this one. if anyone could provide some help it would be appreciated. |
|
Personally I don't see any point in testing the message itself. It just breaks everytime we tweak it which is silly to me from a testing perspective. |
|
I'm still learning on a lot of this testing stuff, so I'll defer to you on that. i was having trouble figuring out where it actually tested that message, but I just found it in the annotations. still not a fan of annotations, but that's an argument for another place. i have removed that annotation assertion. do i need to do another PR, or can you pick up on it from the one if I commit it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is very difficult to view the failure response, since everything is
printed inline. this allows the options to ‘pretty print’ the JSON
output, just like is done in the ‘additional info’.