Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip expected and actual value on assertCookie #19495

Merged
merged 1 commit into from
Jun 6, 2017
Merged

Flip expected and actual value on assertCookie #19495

merged 1 commit into from
Jun 6, 2017

Conversation

eduPHP
Copy link
Contributor

@eduPHP eduPHP commented Jun 6, 2017

Problem:

Test:

    $response->assertCookie("somecookie", 'expected');

Controller:

Cookie::queue('somecookie', 'actual', $days);

phpunit

There was 1 failure:

1) Tests\Feature\CookiesTest::cookie_must_be_stored
Cookie [somecookie] was found, but value [actual] does not match [expected].
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'actual'
+'expected'

Solution:
Flip expected and actual values

Problem: 

Test:
```
    $response->assertCookie("somecookie", 'expected');
```
Controller:

´´´
    Cookie::queue('somecookie', 'actual value', $days);
´´´
phpunit
´´´
There was 1 failure:

1) Tests\Feature\LifetimeCookiesTest::by_accessing_the_affiliation_link_a_cookie_must_be_stored
Cookie [somecookie] was found, but value [actual] does not match [expected].
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'actual'
+'expected'
´´´

Solution:
Flip expected and actual values
@taylorotwell taylorotwell merged commit de8084d into laravel:5.4 Jun 6, 2017
@taylorotwell
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants