Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.7] Resolve Blade facade to named service #25391

Closed
wants to merge 1 commit into from

Conversation

franzliedke
Copy link
Contributor

I am unsure whether the manual resolution was added for a specific purpose. I am assuming it was just there because the first version of the ViewServiceProvider did not register a binding for the Blade compiler.

@franzliedke
Copy link
Contributor Author

The only other facade that does not return a string from getFacadeAccessor() is the Schema facade.

If we replace that logic with a binding (we'd have to register a new one), we could get rid of some complexity because we could require all facades to return a string from that method.

@taylorotwell
Copy link
Member

Hmm, I'm scared to change this in case I forgot some reason I did it this way. 👀

@franzliedke
Copy link
Contributor Author

@taylorotwell I don't see why there should be a reason other than what I wrote:

I am assuming it was just there because the first version of the ViewServiceProvider did not register a binding for the Blade compiler.

We can target it at 5.8, then there's enough time to find out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants