[5.6] Make inequality validation fail on different types rather than 500 #28168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are four types of inequality validators: lt, lte, gt, gte. If these validators reference another attribute, the attribute must be of the same type. Before this change, if the payload has different types, a 500 error is given. However, the type is not determine by the rule configuration, but rather the HTTP request. Instead of throwing an error, just fail the validation.
JonathanGawrych
force-pushed
the
5.6-inequality-validation-fail-not-500
branch
from
3c877f5 to
072dc30
Compare
|
5.6 is no longer supported. If accepted, as a breaking change, master would need to be targeted. If considered a bug, 5.5 could possibly be targeted since it is accepting bug fixes until August. |
|
Please send to 5.8 if this is a bug fix or master if it is a breaking change improvement. |
|
I considered it a bug, because I believe an invalid payload should cause a validation failure, rather than an error to be thrown, that if uncaught will return a 500 internal server error. Because I believe it to be a bug, I was going to target the 5.5 (LTS) branch like the collaboration docs said, but the inequality validators were introduced in 5.6, so I targeted it to 5.6 instead. Based on what taylorotwell said, I'll target 5.8 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are four types of inequality validators:
lt,lte,gt,gte. If these validators reference another attribute, the attribute must be of the same type. Before this change, if the payload has different types, a 500 error is given. However, the type is not determine by the rule configuration, but rather the HTTP request. It shouldn't be an Internal Server Error, when really the request was invalid.