Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Add wherePivot, wherePivotIn Tests #28260

Merged
merged 2 commits into from
Apr 19, 2019
Merged

[5.8] Add wherePivot, wherePivotIn Tests #28260

merged 2 commits into from
Apr 19, 2019

Conversation

ahinkle
Copy link
Contributor

@ahinkle ahinkle commented Apr 18, 2019

This PR adds tests to wherePivot to prevent future issues such as problems (#28251) unintentionally introduced in #28192 (later reverted in 04a547e)

Also adds tests to the untested wherePivotIn method.

@ahinkle ahinkle mentioned this pull request Apr 18, 2019
Closed
@driesvints
Copy link
Member

@ahinkle thanks for sending this in 👍

@duxthefux
Copy link
Contributor

@ahinkle pls make the == comparison in where() strict to ===. See my comment in #28192.

Otherwise you introduce more bugs :-(

@taylorotwell taylorotwell merged commit 68da81b into laravel:5.8 Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahinkle @driesvints @duxthefux @taylorotwell