Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Use @error directive in auth stubs #28272

Closed
wants to merge 4 commits into from
Closed

[5.8] Use @error directive in auth stubs #28272

wants to merge 4 commits into from

Conversation

antimech
Copy link
Contributor

@antimech antimech commented Apr 19, 2019 •
edited
Loading

This makes code pretty neat by default.

Related to #28062

@antimech antimech changed the title WIP: Use @error directive in auth stubs ] Use @error directive in auth stubs Apr 19, 2019
@antimech antimech changed the title ] Use @error directive in auth stubs [5.8] Use @error directive in auth stubs Apr 19, 2019
@taylorotwell
Copy link
Member

Isn't the point you don't need to use $error->first anymore either? Feel free to re-submit with the full changes.

@antimech
Copy link
Contributor Author

@taylorotwell what do you mean by full changes?

@driesvints
Copy link
Member

@antimech see #28273

@antimech
Copy link
Contributor Author

Sorry, I did not notice it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antimech @taylorotwell @driesvints