Add typehints in favour of PHPDocs for TransformsRequest middleware #28373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a minor improvement (and since the project is only targeting >= PHP 7.1) I've updated the
TransformsRequest
middleware to use the type hints where possible and removing the (redundant)@params
and@return
.This PR doesn't touch the
cleanValue
method as it is overloaded and contains support for mixed types.Feel free to reply if this PR needs rework (Since this is my 1st PR on this project)