Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Added support for multiple --path options within migrate commands #28495

Merged

Conversation

nWidart
Copy link
Contributor

@nWidart nWidart commented May 12, 2019

This pull request makes the --path option repeatable. This brings it in line with the migrate:reset command which has the same.

The migrate:status command should receive the same treatment in a subsequent PR.

@GrahamCampbell GrahamCampbell changed the title [5.8] migrate:rollback added support for multiple --path options [5.8] Added support for multiple --path options within migrate commands May 12, 2019
@nWidart
Copy link
Contributor Author

nWidart commented May 12, 2019

Not sure why some tests fail, it's ok locally on php 7.2. They were also fine when the pull requests were split. Maybe the run should be re-triggered?

@driesvints
Copy link
Member

driesvints commented May 12, 2019

@nWidart unrelated to the PR. We're currently experiencing some random Memcached issues on the build. Restarted it for you.

@taylorotwell taylorotwell merged commit 4fc4f51 into laravel:5.8 May 13, 2019
@nWidart nWidart deleted the feature/migrate-rollback-multiple-paths branch May 14, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants