New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Fix validation with multiple passes() calls #28502

Merged

taylorotwell merged 1 commit into laravel:5.8 from staudenmeir:validation

May 13, 2019

Contributor

staudenmeir commented May 12, 2019

Validation incorrectly passes after the first time if required isn't the first rule:

$v = Validator::make([], ['foo' => 'required|string']);
dump($v->passes()); // false
dump($v->passes()); // false

$v = Validator::make([], ['foo' => 'string|required']);
dump($v->passes()); // false
dump($v->passes()); // true

We have to reset the $failedRules property every time passes() gets called.

Fixes #28480.


          Fix validation with multiple passes() calls

0e52e47

taylorotwell merged commit f5d37e4 into laravel:5.8

staudenmeir deleted the validation branch

May 13, 2019 02:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet