Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Support headers with notification mail message #28534

Closed
wants to merge 1 commit into from

Conversation

dwightwatson
Copy link
Contributor

This extends the MailMessage used when creating basic mail notifications to support adding headers. It looks like this has been discussed before (see laravel/ideas#475 and in a couple of other places) but there doesn't appear to be a stable solution, apart from creating mailables and returning those instead.

The common use-case for custom email headers is that they can be used for tracking purposes. For example, Mailgun uses headers to help breakdown emails sent for analytics purposes.

@dwightwatson dwightwatson changed the title Support headers with notification mail message [5.8] Support headers with notification mail message May 15, 2019
@dwightwatson
Copy link
Contributor Author

I think a better approach here might be to fall in line with Mailable and provide callbacks that give more control over the final message. I'll open another PR that does that instead.

@Cyrille37
Copy link
Contributor

Hello. Thanks again @dwightwatson for your work. With this PR it was very easy to understand and extends a Laravel 5.5 to add header feature to MailMessage. Thanks & cheers :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants