Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.9] Drop Carbon v1 #28683

Merged
merged 1 commit into from
May 31, 2019
Merged

[5.9] Drop Carbon v1 #28683

merged 1 commit into from
May 31, 2019

Conversation

driesvints
Copy link
Member

Carbon v1 is now warning to drop support and upgrade to v2 instead so it's best that we drop support for it in newer versions. See briannesbitt/Carbon#1685

Carbon v1 is now warning to drop support and upgrade to v2 instead so it's best that we drop support for it in newer versions. See briannesbitt/Carbon#1685
@taylorotwell taylorotwell merged commit d9ffff2 into laravel:master May 31, 2019
@driesvints driesvints deleted the drop-carbon-1-support branch May 31, 2019 13:03
@kylekatarnls
Copy link
Contributor

Thanks @driesvints it will help me to focus maintenance efforts on Carbon 2.

@bobdenotter It's for 5.9, not 5.8. But indeed, the minimum PHP version becomes 7.1.8 de facto and should be reflected in the composer.json and doc.

For the record, we need 7.1.8 because of this bug fixed in this version:

Fixed bug #74852 (property_exists returns true on unknown DateInterval property).
https://bugs.php.net/bug.php?id=74852

@kylekatarnls
Copy link
Contributor

I will check if we can work around this bug and support 7.1.3.

@driesvints
Copy link
Member Author

@bobdenotter @kylekatarnls the next Laravel version has a minimum requirement of PHP 7.2 so we should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants