New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Check presence of force flag in command signature #28742

Merged

taylorotwell merged 1 commit into laravel:5.8 from nie7321:confirmable-force

Jun 6, 2019

Contributor

nie7321 commented Jun 5, 2019 •

edited

Loading

When using the ConfirmableTrait, you get an exception in production if you don't have force in the command signature:

Symfony\Component\Console\Exception\InvalidArgumentException: The "force" option does not exist.

This was a non-obvious error, and caught me by surprise during a deployment -- you'd only get it when your app was in production mode.

This PR makes force an optional feature when using ConfirmableTrait.


          Check presence of force flag in command signature

cc334d9

taylorotwell merged commit 5714b21 into laravel:5.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet