[5.8] Fix strict comparison in redis configuration Parsing #28830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper fix for issue #28829.
Problem:
Input of the function:
[0 => 'url1', 1 => 'url2', 2 => 'url3']
Expected output:
[0 => 'url1', 1 => 'url2', 2 => 'url3']
Actual output:
[1 => 'url2', 2 => 'url3']
This is about strict comparison in
in_array
method:Thanks.
Matt'
PS: Again, this would not happen with tests.
I have no time to add proper tests on all of this RedisManager, but I think this is something we should have. Can be a good first PR for someone who want to contribute.