Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix Builder::dump() and dd() with global scopes #28858

Merged
merged 1 commit into from
Jun 17, 2019
Merged

[5.8] Fix Builder::dump() and dd() with global scopes #28858

merged 1 commit into from
Jun 17, 2019

Conversation

staudenmeir
Copy link
Contributor

Eloquent\Builder::dump() and dd() don't include global scopes, we need to call toBase() first.

There aren't any tests for these methods.

@taylorotwell taylorotwell merged commit cf90774 into laravel:5.8 Jun 17, 2019
@staudenmeir staudenmeir deleted the eloquent-dump branch June 18, 2019 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants