Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.8] Fixed validator not failing on custom rule when message is null #29174

Merged
merged 1 commit into from
Jul 15, 2019
Merged

[5.8] Fixed validator not failing on custom rule when message is null #29174

merged 1 commit into from
Jul 15, 2019

Conversation

stevebauman
Copy link
Contributor

Issue: #29171

@stevebauman stevebauman changed the title Fixed validator not failing on custom rule when message is null [5.8] Fixed validator not failing on custom rule when message is null Jul 15, 2019
@taylorotwell taylorotwell merged commit ec6bf0a into laravel:5.8 Jul 15, 2019
@StefanPrintezis
Copy link

StefanPrintezis commented Jul 15, 2019 •
edited
Loading

We can also prevent messages from ever returning null since that’s not allowed to prevent any other issues. Might be a cleaner approach.

The return type of message() can be :string since 5.8 requires at least php 7.1.3.
Changing the return type will break backwards compatibility tho. So maybe next minor version?

@chriskonnertz
Copy link

chriskonnertz commented Jul 16, 2019 •
edited
Loading

Larvel does not use type hints for return values at the moment.

@stevebauman stevebauman deleted the patch-2 branch July 16, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevebauman @StefanPrintezis @chriskonnertz @taylorotwell