Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix DELETE queries with joins on PostgreSQL #29313

Merged
merged 1 commit into from
Jul 29, 2019
Merged

[5.8] Fix DELETE queries with joins on PostgreSQL #29313

merged 1 commit into from
Jul 29, 2019

Conversation

staudenmeir
Copy link
Contributor

On PostgreSQL, Laravel implements DELETE queries with joins by adding their constraints after the WHERE constraints. If a query only has joins, the constraints aren't compiled:

DB::table('comments')
    ->join('posts', function ($join) {
        $join->on('posts.id', '=', 'comments.post_id')
            ->where('posts.active', 0);
    })
    ->delete();
# expected
delete from "comments" USING "posts"
where "posts"."id" = "comments"."post_id" and "posts"."active" = 0

# actual
delete from "comments" USING "posts"

@taylorotwell taylorotwell merged commit af46990 into laravel:5.8 Jul 29, 2019
@staudenmeir staudenmeir deleted the pgsql-delete branch July 29, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants