[5.8] Replace global helper with container call in Exception Handler #29635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
approved these changes
Aug 19, 2019
|
Doesn't matter either way. This is within the foundation component. |
|
That seems strange to me, because we already have container instantiated, why should we reinstantiate it using global helper? |
|
The container is a singleton and does not get reinstantiated with the global helper? |
|
Yes, but if it's already assigned in class field, why shouldn't we use it instead? |
antonkomarev
deleted the
refactor/use-container-instead-of-global-helper-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @crynobone noted in #29564 we could use container instead of global helper method.