[6.x] Revert #27807 "Extract registered event and login to registered method" #29875
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 708975a.
taylorotwell
added a commit
that referenced
this pull request
Sep 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #29874 by reverting the changes to the
RegistersUserstrait introduced in #27807.Because
RegistersUsersis a trait, classesuseing it directly can't extend its functionality with theparentkeyword as suggested in the upgrade guide, which means that to 'extend' a method we would have to override it completely and copy in any of the trait's functionality that we wanted to keep (or use something weird likeuse RegistersUsers { registered as afterRegistered; }).It worked great before, and let people hook into the registration process or return a different response from the registration controller.
If we don't want to provide that functionality at all, we should take out the
registeredmethod completely, since splitting it in two doesn't accomplish anything if we can't extend either of them anyway.If this is merged I'll submit a PR to update the docs. We should probably still mention this somewhere though, since people following the letter of the upgrade guide would have broken their apps by using the
parentkeyword.