Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Revert "[6.x] Removed static return type PHPDoc from first()" #29892

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

driesvints
Copy link
Member

Reverts #29877

Removing the static typehint will prevent the detection by IDE's of custom methods on the implementing model.

As noted by @sisve here: #29877 (comment)

@taylorotwell taylorotwell merged commit 438b78d into 6.x Sep 6, 2019
@driesvints driesvints deleted the revert-29877-patch-1 branch September 6, 2019 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants