Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.x] Fix return types for mock and spy test helpers #29922

Merged
merged 2 commits into from
Sep 9, 2019
Merged

[6.x] Fix return types for mock and spy test helpers #29922

merged 2 commits into from
Sep 9, 2019

Conversation

SjorsO
Copy link
Contributor

@SjorsO SjorsO commented Sep 9, 2019

Both $this->mock() and $this->spy() return an instance of Mockery\MockInterface.

Currently, without this return type:
image

With this PR:
image

@driesvints
Copy link
Member

@SjorsO can you use FQN for the namespaces?

@SjorsO
Copy link
Contributor Author

SjorsO commented Sep 9, 2019

Done

@taylorotwell taylorotwell merged commit 30a56eb into laravel:6.x Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SjorsO @driesvints @taylorotwell