[6.x] Convert call_user_func where appropriate to native calls

src/Illuminate/Console/ConfirmableTrait.php

@@ -19,7 +19,7 @@ public function confirmToProceed($warning = 'Application In Production!', $callb
     {
         $callback = is_null($callback) ? $this->getDefaultConfirmCallback() : $callback;
 
-        $shouldConfirm = $callback instanceof Closure ? call_user_func($callback) : $callback;
+        $shouldConfirm = $callback instanceof Closure ? $callback() : $callback;
 
         if ($shouldConfirm) {
             if ($this->hasOption('force') && $this->option('force')) {

src/Illuminate/Database/Eloquent/Builder.php

@@ -473,7 +473,7 @@ public function firstOr($columns = ['*'], Closure $callback = null)
             return $model;
         }
 
-        return call_user_func($callback);
+        return $callback();
     }
 
     /**

src/Illuminate/Database/Eloquent/FactoryBuilder.php

@@ -344,10 +344,7 @@ protected function stateAttributes($state, array $attributes)
             return $stateAttributes;
         }
 
-        return call_user_func(
-            $stateAttributes,
-            $this->faker, $attributes
-        );
+        return $stateAttributes($this->faker, $attributes);
     }
 
     /**

src/Illuminate/Database/Eloquent/Model.php

@@ -278,7 +278,7 @@ public static function withoutTouchingOn(array $models, callable $callback)
         static::$ignoreOnTouch = array_values(array_merge(static::$ignoreOnTouch, $models));
 
         try {
-            call_user_func($callback);
+            $callback();
         } finally {
             static::$ignoreOnTouch = array_values(array_diff(static::$ignoreOnTouch, $models));
         }

src/Illuminate/Database/Eloquent/Relations/Relation.php

@@ -87,7 +87,7 @@ public static function noConstraints(Closure $callback)
         // off of the bindings, leaving only the constraints that the developers put
         // as "extra" on the relationships, and not original relation constraints.
         try {
-            return call_user_func($callback);
+            return $callback();
         } finally {
             static::$constraints = $previous;
         }

src/Illuminate/Database/Migrations/MigrationCreator.php

@@ -157,7 +157,7 @@ protected function getPath($name, $path)
     protected function firePostCreateHooks($table)
     {
         foreach ($this->postCreate as $callback) {
-            call_user_func($callback, $table);
+            $callback($table);
         }
     }
 

src/Illuminate/Database/Query/Builder.php

@@ -433,7 +433,7 @@ public function join($table, $first, $operator = null, $second = null, $type = '
         // is trying to build a join with a complex "on" clause containing more than
         // one condition, so we'll add the join and call a Closure with the query.
         if ($first instanceof Closure) {
-            call_user_func($first, $join);
+            $first($join);
 
             $this->joins[] = $join;
 

src/Illuminate/Foundation/Application.php

@@ -864,7 +864,7 @@ public function booted($callback)
     protected function fireAppCallbacks(array $callbacks)
     {
         foreach ($callbacks as $callback) {
-            call_user_func($callback, $this);
+            $callback($this);
         }
     }
 

src/Illuminate/Foundation/EnvironmentDetector.php

@@ -31,7 +31,7 @@ public function detect(Closure $callback, $consoleArgs = null)
      */
     protected function detectWebEnvironment(Closure $callback)
     {
-        return call_user_func($callback);
+        return $callback();
     }
 
     /**

src/Illuminate/Foundation/Testing/TestCase.php

@@ -82,7 +82,7 @@ protected function setUp(): void
         $this->setUpTraits();
 
         foreach ($this->afterApplicationCreatedCallbacks as $callback) {
-            call_user_func($callback);
+            $callback();
         }
 
         Facade::clearResolvedInstances();
@@ -206,7 +206,7 @@ public function afterApplicationCreated(callable $callback)
         $this->afterApplicationCreatedCallbacks[] = $callback;
 
         if ($this->setUpHasRun) {
-            call_user_func($callback);
+            $callback();
         }
     }
 
@@ -230,7 +230,7 @@ protected function callBeforeApplicationDestroyedCallbacks()
     {
         foreach ($this->beforeApplicationDestroyedCallbacks as $callback) {
             try {
-                call_user_func($callback);
+                $callback();
             } catch (Throwable $e) {
                 if (! $this->callbackException) {
                     $this->callbackException = $e;

src/Illuminate/Mail/Mailer.php

@@ -239,7 +239,7 @@ public function send($view, array $data = [], $callback = null)
         // Once we have retrieved the view content for the e-mail we will set the body
         // of this message using the HTML type, which will provide a simple wrapper
         // to creating view based emails that are able to receive arrays of data.
-        call_user_func($callback, $message);
+        $callback($message);
 
         $this->addContent($message, $view, $plain, $raw, $data);
 

src/Illuminate/Redis/RedisManager.php

@@ -162,7 +162,7 @@ protected function connector()
         $customCreator = $this->customCreators[$this->driver] ?? null;
 
         if ($customCreator) {
-            return call_user_func($customCreator);
+            return $customCreator();
         }
 
         switch ($this->driver) {

src/Illuminate/Routing/RouteBinding.php

@@ -41,7 +41,7 @@ protected static function createClassBinding($container, $binding)
 
             $callable = [$container->make($class), $method];
 
-            return call_user_func($callable, $value, $route);
+            return $callable($value, $route);
         };
     }
 
@@ -73,7 +73,7 @@ public static function forModel($container, $class, $callback = null)
             // what we should do when the model is not found. This just gives these
             // developer a little greater flexibility to decide what will happen.
             if ($callback instanceof Closure) {
-                return call_user_func($callback, $value);
+                return $callback($value);
             }
 
             throw (new ModelNotFoundException)->setModel($class);

src/Illuminate/Support/Arr.php

@@ -172,7 +172,7 @@ public static function first($array, callable $callback = null, $default = null)
         }
 
         foreach ($array as $key => $value) {
-            if (call_user_func($callback, $value, $key)) {
+            if ($callback($value, $key)) {
                 return $value;
             }
         }

src/Illuminate/Support/Collection.php

@@ -936,7 +936,7 @@ public function search($value, $strict = false)
         }
 
         foreach ($this->items as $key => $item) {
-            if (call_user_func($value, $item, $key)) {
+            if ($value($item, $key)) {
                 return $key;
             }
         }

src/Illuminate/Support/Pluralizer.php

@@ -111,8 +111,8 @@ protected static function matchCase($value, $comparison)
         $functions = ['mb_strtolower', 'mb_strtoupper', 'ucfirst', 'ucwords'];
 
         foreach ($functions as $function) {
-            if (call_user_func($function, $comparison) === $comparison) {
-                return call_user_func($function, $value);
+            if ($function($comparison) === $comparison) {
+                return $function($value);
             }
         }
 

src/Illuminate/Validation/Validator.php

@@ -286,7 +286,7 @@ public function passes()
         // fire them off. This gives the callbacks a chance to perform all kinds
         // of other validation that needs to get wrapped up in this operation.
         foreach ($this->after as $after) {
-            call_user_func($after);
+            $after();
         }
 
         return $this->messages->isEmpty();
@@ -870,7 +870,7 @@ public function sometimes($attribute, $rules, callable $callback)
     {
         $payload = new Fluent($this->getData());
 
-        if (call_user_func($callback, $payload)) {
+        if ($callback($payload)) {
             foreach ((array) $attribute as $key) {
                 $this->addRules([$key => $rules]);
             }

src/Illuminate/View/Compilers/BladeCompiler.php

@@ -326,7 +326,7 @@ protected function parseToken($token)
     protected function compileExtensions($value)
     {
         foreach ($this->extensions as $compiler) {
-            $value = call_user_func($compiler, $value, $this);
+            $value = $compiler($value, $this);
         }
 
         return $value;

src/Illuminate/View/View.php

@@ -90,7 +90,7 @@ public function render(callable $callback = null)
         try {
             $contents = $this->renderContents();
 
-            $response = isset($callback) ? call_user_func($callback, $this, $contents) : null;
+            $response = isset($callback) ? $callback($this, $contents) : null;
 
             // Once we have the contents of the view, we will flush the sections if we are
             // done rendering all views so that there is nothing left hanging over when