[7.x] Configure Schema on migration instantiation #29983
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to abstract Migration class
$schema
property with configured connection from Migration'sgetConnection()
method.Motivation
Migration has
getConnection()
method which used inside of the Migrator class to determine if schema transactions are supported:But when migration is running Schema facade is being used and it doesn't care about
getConnection()
method of the migration. Migrator checks connection and enables transactions, but in fact migrations could be executed on another connection.To respect database connection, instead of this:
We should write this:
New Implementation
Similar approach implemented in Laravel Telescope, but there it doesn't get connection name from
getConnection()
method, what means that Migrator wouldn't determine correctly if schema transactions are supported.