-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.x] Fix migration class duplicate check #30095
Conversation
This changes a method signature and may break existing code. Should it target another Laravel version? |
I am wondering if I can add another method to verify that it already exists, but that is not in line with the DRY principle.Let me think about it |
I added a default parameter, so the code that depends on this method can run |
Nice work ⭐
It might bring issues if You probably can Nevertheless, you might want to wait for official feedback to keep working on it. |
While this does add an argument to a protected method, the likelihood of any given Laravel application extending this specific method seems pretty negligible to me. |
This broke the build. @ROOKIE20570 please make sure that the tests pass next time, thanks. |
Sorry, I was not familiar with it before, I will definitely do better next time. |
@ROOKIE20570 no worries at all 👍 |
Closes #30062.