[6.x] Added Macroable trait to Illuminate\Console\Scheduling\Schedule class #31354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds the
Macroable
trait to theIlluminate\Console\Scheduling\Schedule
class, allowing developers, both application and package, to add custom methods to the Schedule class.The main benefit I see here is that third-party package developers can add methods to the Schedule class that will schedule commands / closures from their package, letting the package-user to optionally enable those scheduled commands by calling the macro'd function. This would act in the same way as many packages create Route macros to register routes.
There won't be any breaking changes here, or any conflicts that I can see as the Schedule class did not have any magic
__call()
or__callStatic()
methods to begin with.This trait has already been added to the
Illuminate\Console\Scheduling\Event
class, can't see any reason why it can't be added to the scheduler.