Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fix testing with unencrypted cookies #31390

Merged
merged 4 commits into from
Feb 10, 2020
Merged

[6.x] Fix testing with unencrypted cookies #31390

merged 4 commits into from
Feb 10, 2020

Conversation

gentcys
Copy link
Contributor

@gentcys gentcys commented Feb 7, 2020

This PR provide a way to specify cookies will not be encrypted before sending with the request.

$this->withCookie('bar', 'qux')
     ->withUnencryptedCookie('foo', 'bar')
     ->get('/');
$this->withCookies($cookies) // cookies will be encrypted
     ->withUnencryptedCookies($unencryptedCookies) // cookies will not be encrypted
     ->get('/');

Fixes #31282

@gentcys gentcys closed this Feb 7, 2020
@gentcys gentcys reopened this Feb 7, 2020
@taylorotwell
Copy link
Member

This feels like a pretty big breaking change to make withCookies no longer encrypted? Why not make the method withUnencryptedCookie so we don't have to have that breaking change?

@gentcys
Copy link
Contributor Author

gentcys commented Feb 7, 2020

@taylorotwell It's a great idea.

@taylorotwell taylorotwell merged commit 6088728 into laravel:6.x Feb 10, 2020
@gentcys gentcys deleted the testing-with-unencrypted-cookies branch February 11, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing with unencrypted cookies doesn't work
2 participants