[8.x] Bumped minimum symfony #31542
Merged
[8.x] Bumped minimum symfony #31542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we need to add another component to make tests pass. |
|
Hmmm, let me investigate. Maybe we have an implicit dependency we should probably add into 6.x and 7.x too. |
|
Seems to have been caused by symfony/http-foundation@63f4263. |
GrahamCampbell
changed the title
|
I am going to recommend that they revert their change, as it is a BC break. It will actually break Laravel 7.x too, once Symfony 5.1.0 is out. symfony/symfony#35807 |
|
Let's see what they say to my comments. If they don't want to revert and merge my PR, then we should add the mime dependency to the laravel/framework 7.x branch. |
|
BTW, thank you for testing with unreleased versions, helping spot issues as early as possible! |
GrahamCampbell
force-pushed
the
symfony
branch
from
25cc5ff to
3a16a15
Compare
|
Ok, rebased. Now let's see if the tests pass. |
GrahamCampbell
changed the title
|
Passing. 🎉 |
GrahamCampbell
force-pushed
the
symfony
branch
from
3a16a15 to
92c98bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the minimum version of Symfony to 5.1.