[6.x] Fix *scan methods for phpredis #32336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #24222, previously fixed in #24313 but reverted by broken test.
hscan, zscan, sscan problem on phpredis that it can't iterate sets with cursor still occurs 6.x, 7.x branch so I requested this pr. If something is wrong with pull request process, please let me know.
This PR fixes *scan methods for phpredis and add missing *scan tests to redis connection.
Current Behaviour
Redis Facade set phpredis as client returns no cursor with same results on every *scan call. So it can not iterate sets that has many members.
Fixed Behaviour
Returns cursor with results on *scan methods for phpredis. This behaviour is compatible with predis adapter.
It can iterate over sets until all member has been returned.